?

Log in

No account? Create an account
export_comments.bml - LiveJournal Client Discussions [entries|archive|friends|userinfo]
LiveJournal Client Discussions

[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

export_comments.bml [Mar. 27th, 2006|12:11 pm]
LiveJournal Client Discussions

lj_clients

[fg]
export_comments.bml has a model for caching comments that could be improved by supporting a lastsync parameter like getevents does.

right now, to answer the question "has a comment been deleted since i last checked?", you have to call export_comments.bml?get=comment_meta from 0 to maxid. a user with a journal nearing 100,000 comments (of which i'm sure there are a few) will have to download 100,000 (meta) comments every time he syncs, even if nothing has changed.

xb95, i don't have any means to test it, but i'd be happy to submit a patch if that would help.
linkReply

Comments:
From: evan
2006-04-03 05:26 am (UTC)
it just occurred to me why this may be the case:
lj may not have an column over the comments table that includes the last-modifed date. so there's no way to get the changes since a last check. even if there was such a column, unless there's an index on it, finding the relevant entries is a table scan anyway.
(Reply) (Thread)
[User Picture]From: fg
2006-04-03 06:33 am (UTC)
i just checked, and you're right. events have a revtime prop that getevents uses, but there's no similar prop for comments.

i guess maintaining such a property for comments could be more expensive on the server than the occasional archive client sucking down needless data.

... until archive clients take over the world, that is. MUAH HAH HA!
(Reply) (Parent) (Thread)